[webkit-changes] [WebKit/WebKit] c6b771: [CSS] Nesting '&' selector is not a pseudo class

Matthieu Dubet noreply at github.com
Mon Jun 26 02:21:10 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c6b7717a83e78c6d5c850610338fb2644bdf2fbd
      https://github.com/WebKit/WebKit/commit/c6b7717a83e78c6d5c850610338fb2644bdf2fbd
  Author: Matthieu Dubet <m_dubet at apple.com>
  Date:   2023-06-26 (Mon, 26 Jun 2023)

  Changed paths:
    M Source/WebCore/css/CSSSelector.cpp
    M Source/WebCore/css/CSSSelector.h
    M Source/WebCore/css/CSSSelectorList.cpp
    M Source/WebCore/css/SelectorChecker.cpp
    M Source/WebCore/css/parser/CSSParserImpl.cpp
    M Source/WebCore/css/parser/CSSSelectorParser.cpp
    M Source/WebCore/cssjit/SelectorCompiler.cpp
    M Source/WebCore/style/RuleSet.cpp

  Log Message:
  -----------
  [CSS] Nesting '&' selector is not a pseudo class
https://bugs.webkit.org/show_bug.cgi?id=252188
rdar://107328044

Reviewed by Tim Nguyen.

https://drafts.csswg.org/css-nesting/#nest-selector

The nesting selector, written as '&', is a new selector
and not a pseudo class.
This a pure refactoring without any functional change.

* Source/WebCore/css/CSSSelector.cpp:
(WebCore::simpleSelectorSpecificity):
(WebCore::CSSSelector::selectorText const):
(WebCore::CSSSelector::resolveNestingParentSelectors):
(WebCore::CSSSelector::replaceNestingParentByPseudoClassScope):
(WebCore::CSSSelector::hasExplicitNestingParent const):
* Source/WebCore/css/CSSSelector.h:
* Source/WebCore/css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::hasOnlyNestingSelector const):
* Source/WebCore/css/SelectorChecker.cpp:
(WebCore::canMatchHoverOrActiveInQuirksMode):
(WebCore::SelectorChecker::checkOne const):
* Source/WebCore/css/parser/CSSParserImpl.cpp:
(WebCore::CSSParserImpl::createNestingParentRule):
* Source/WebCore/css/parser/CSSSelectorParser.cpp:
(WebCore::CSSSelectorParser::consumeNesting):
* Source/WebCore/cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::constructFragmentsInternal):
* Source/WebCore/style/RuleSet.cpp:
(WebCore::Style::RuleSet::addRule):

Canonical link: https://commits.webkit.org/265509@main




More information about the webkit-changes mailing list