[webkit-changes] [WebKit/WebKit] 1f2d2a: input type=tel test case fail in css/selectors/dir...

Ryosuke Niwa noreply at github.com
Sat Jun 24 19:27:58 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1f2d2a92eeb831bedd01bbb5b694a0e29fa9af81
      https://github.com/WebKit/WebKit/commit/1f2d2a92eeb831bedd01bbb5b694a0e29fa9af81
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-06-24 (Sat, 24 Jun 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/selectors/dir-pseudo-on-input-element-expected.txt
    M LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/selectors/dir-pseudo-on-input-element-expected.txt
    M Source/WebCore/css/html.css
    M Source/WebCore/html/HTMLElement.cpp
    M Source/WebCore/html/HTMLElement.h
    M Source/WebCore/html/HTMLInputElement.cpp

  Log Message:
  -----------
  input type=tel test case fail in css/selectors/dir-pseudo-on-input-element.html
https://bugs.webkit.org/show_bug.cgi?id=258326

Reviewed by Tim Nguyen.

The bug was caused by the missing :dir rule to force direction: ltr on input[type=tel] when there isn't
a valid dir content attribute specified on the element as well as the lack of style invalidation when
input element's type changes. This patch fixes both problems.

* LayoutTests/imported/w3c/web-platform-tests/css/selectors/dir-pseudo-on-input-element-expected.txt:
* LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/css/selectors/dir-pseudo-on-input-element-expected.txt:
* Source/WebCore/css/html.css:
(input[type=tel i]:dir(ltr)):
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::updateTextDirectionalityAfterTelephoneInputTypeChange):
* Source/WebCore/html/HTMLElement.h:
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):

Canonical link: https://commits.webkit.org/265500@main




More information about the webkit-changes mailing list