[webkit-changes] [WebKit/WebKit] 8da688: [CSS-Text-Decoration] Text decorations should prop...

Ahmad Saleem noreply at github.com
Fri Jun 23 15:56:05 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8da68845476a06674ef08f1639f124cb7ac535c9
      https://github.com/WebKit/WebKit/commit/8da68845476a06674ef08f1639f124cb7ac535c9
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-06-23 (Fri, 23 Jun 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-propagation-05-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-propagation-05.html
    M Source/WebCore/style/StyleAdjuster.cpp

  Log Message:
  -----------
  [CSS-Text-Decoration] Text decorations should propagate into tables

https://bugs.webkit.org/show_bug.cgi?id=258465

Reviewed by Tim Nguyen.

This patch aligns WebKit with Gecko / Firefox, Blink / Chromium and Web-Spec [1]:

Partial Merge: https://src.chromium.org/viewvc/blink?view=revision&revision=199637

This patch fixes our text-decoration propagation logic to allow
propagation into "display: table" elements. These elements are
block-level element which participates in a block formatting context
and so decorations should propagate into them.

[1] https://drafts.csswg.org/css-text-decor-3/#line-decoration

* Source/WebCore/style/StyleAdjuster.cpp:
(shouldInheritTextDecorationsInEffect): Remove 'Table' as per commit log
* LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-propagation-05.html: Add Test Case
* LayoutTests/imported/w3c/web-platform-tests/css/css-text-decor/text-decoration-propagation-05-expected.html: Add Test Case Expectation

Canonical link: https://commits.webkit.org/265488@main




More information about the webkit-changes mailing list