[webkit-changes] [WebKit/WebKit] 677b44: Throw when constructing a SharedWorker in a detach...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 677b4473a8cb849af5d8af685b7b9e72e838cb3c
      https://github.com/WebKit/WebKit/commit/677b4473a8cb849af5d8af685b7b9e72e838cb3c
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-06-23 (Fri, 23 Jun 2023)

  Changed paths:
    A LayoutTests/http/tests/workers/shared/resources/start-worker-detached-frame-iframe.html
    A LayoutTests/http/tests/workers/shared/start-worker-detached-frame-expected.txt
    A LayoutTests/http/tests/workers/shared/start-worker-detached-frame.html
    M Source/WebCore/workers/shared/SharedWorker.cpp

  Log Message:
  -----------
  Throw when constructing a SharedWorker in a detached document
https://bugs.webkit.org/show_bug.cgi?id=258477
rdar://110231627

Reviewed by Sihui Liu and Brent Fulgham.

Throw an exception when constructing a SharedWorker in a detached iframe, similarly
to what Chrome and Firefox are already doing. Previously, we would successfully
create the SharedWorker but the topOrigin would be wrong in the case of a third-party
iframe and we would hit an assertion later on.

* LayoutTests/http/tests/workers/shared/resources/start-worker-detached-frame-iframe.html: Added.
* LayoutTests/http/tests/workers/shared/start-worker-detached-frame-expected.txt: Added.
* LayoutTests/http/tests/workers/shared/start-worker-detached-frame.html: Added.
* Source/WebCore/workers/shared/SharedWorker.cpp:
(WebCore::SharedWorker::create):

Canonical link: https://commits.webkit.org/265483@main