[webkit-changes] [WebKit/WebKit] b2c434: [WebVTT] Cues with line setting containing aligmen...
Jer Noble
noreply at github.com
Fri Jun 23 12:17:36 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b2c434a9b4567ec35d7a1038784cf144b2e050bc
https://github.com/WebKit/WebKit/commit/b2c434a9b4567ec35d7a1038784cf144b2e050bc
Author: Jer Noble <jer.noble at apple.com>
Date: 2023-06-23 (Fri, 23 Jun 2023)
Changed paths:
A LayoutTests/media/track/captions-webvtt/line-align.vtt
A LayoutTests/media/track/webvtt-line-align-expected.txt
A LayoutTests/media/track/webvtt-line-align.html
M Source/WebCore/html/track/VTTCue.cpp
Log Message:
-----------
[WebVTT] Cues with line setting containing aligment parse as 'start'
https://bugs.webkit.org/show_bug.cgi?id=258456
rdar://111220055
Reviewed by Eric Carlson.
The line alignment settings are already parsed, but not stored in
an ivar. Even though layout using those alignment values is not
yet implemented, we should at least parse the correct values from
source WebVTT.
* LayoutTests/media/track/captions-webvtt/line-align.vtt: Added.
* LayoutTests/media/track/webvtt-line-align-expected.txt: Added.
* LayoutTests/media/track/webvtt-line-align.html: Added.
* Source/WebCore/html/track/VTTCue.cpp:
(WebCore::VTTCue::settingName):
(WebCore::VTTCue::setCueSettings):
Canonical link: https://commits.webkit.org/265472@main
More information about the webkit-changes
mailing list