[webkit-changes] [WebKit/WebKit] a4c5bc: Calculate CSS unit `x` as resolution for calc comb...

cybai (Haku) noreply at github.com
Fri Jun 23 11:39:20 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a4c5bcd2ebf9effc1d52f8dbc298f46b08c1eb64
      https://github.com/WebKit/WebKit/commit/a4c5bcd2ebf9effc1d52f8dbc298f46b08c1eb64
  Author: Cheng-You Bai <cyb.ai.815 at gmail.com>
  Date:   2023-06-23 (Fri, 23 Jun 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-parsing-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-parsing.html
    M Source/WebCore/css/calc/CSSCalcCategoryMapping.cpp

  Log Message:
  -----------
  Calculate CSS unit `x` as resolution for calc combination
https://bugs.webkit.org/show_bug.cgi?id=257717

Reviewed by Tim Nguyen.

Previously, `x` was calculated as `other`category so it cannot
be canonicalized to `dppx` unit correctly. Thus, in this patch,
we'll calculate `x` as `resolution` category in calc combination
to fix the issue.

* LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-parsing-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-images/image-set/image-set-parsing.html:
* Source/WebCore/css/calc/CSSCalcCategoryMapping.cpp:
(WebCore::calculationCategoryForCombination):

Canonical link: https://commits.webkit.org/265469@main




More information about the webkit-changes mailing list