[webkit-changes] [WebKit/WebKit] 7798da: [WebVTT] Cues with position setting containing ali...
Jer Noble
noreply at github.com
Fri Jun 23 09:10:49 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7798da0bec55b133d9d63ea9dd37c9be06f4b1bf
https://github.com/WebKit/WebKit/commit/7798da0bec55b133d9d63ea9dd37c9be06f4b1bf
Author: Jer Noble <jer.noble at apple.com>
Date: 2023-06-23 (Fri, 23 Jun 2023)
Changed paths:
A LayoutTests/media/track/captions-webvtt/position-align.vtt
A LayoutTests/media/track/webvtt-position-align-expected.txt
A LayoutTests/media/track/webvtt-position-align.html
M Source/WebCore/html/track/VTTCue.cpp
Log Message:
-----------
[WebVTT] Cues with position setting containing aligment parse as 'auto'
https://bugs.webkit.org/show_bug.cgi?id=258431
rdar://111196313
Reviewed by Eric Carlson.
WebVTT cues which include position alignment values have those positions rejected
by the parser, leading to broken layout issues. Even without adding full support
for those alignments, we can at least not reject those values and achieve partially
correct layouts.
* LayoutTests/media/track/captions-webvtt/position-align.vtt: Added.
* LayoutTests/media/track/webvtt-position-align-expected.txt: Added.
* LayoutTests/media/track/webvtt-position-align.html: Added.
* Source/WebCore/html/track/VTTCue.cpp:
(WebCore::VTTCue::setCueSettings):
Canonical link: https://commits.webkit.org/265465@main
More information about the webkit-changes
mailing list