[webkit-changes] [WebKit/WebKit] b33ade: ASSERTION FAILED: firstChild():[ macOS ] media/tra...

Eric Carlson noreply at github.com
Thu Jun 22 12:39:14 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b33adedfb11722f4b58923457939f6fabe613a4b
      https://github.com/WebKit/WebKit/commit/b33adedfb11722f4b58923457939f6fabe613a4b
  Author: Eric Carlson <eric.carlson at apple.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderVTTCue.cpp

  Log Message:
  -----------
  ASSERTION FAILED: firstChild():[ macOS ] media/track/track-cues-missed.html is a flaky test.
https://bugs.webkit.org/show_bug.cgi?id=258183
rdar://110876540

Reviewed by Andy Estes.

* Source/WebCore/rendering/RenderVTTCue.cpp:
(WebCore::RenderVTTCue::isOutside const): Return early if firstChild() return null.
(WebCore::RenderVTTCue::isOverlapping const): Ditto.
(WebCore::RenderVTTCue::overlappingObject const): Ditto.
(WebCore::RenderVTTCue::moveIfNecessaryToKeepWithinContainer): Ditto.
(WebCore::RenderVTTCue::findNonOverlappingPosition const): Ditto.

Canonical link: https://commits.webkit.org/265420@main




More information about the webkit-changes mailing list