[webkit-changes] [WebKit/WebKit] 5f9e42: [webkitpy] Avoid autoinstalling libraries in init

Jonathan Bedard noreply at github.com
Wed Jun 21 16:42:56 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5f9e420cedb1ad9e41602f43e9423e10c9a1b71a
      https://github.com/WebKit/WebKit/commit/5f9e420cedb1ad9e41602f43e9423e10c9a1b71a
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2023-06-21 (Wed, 21 Jun 2023)

  Changed paths:
    M Tools/Scripts/libraries/webkitbugspy/setup.py
    M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py
    M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py
    M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py
    M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/issue.py
    M Tools/Scripts/libraries/webkitbugspy/webkitbugspy/user.py
    M Tools/Scripts/libraries/webkitcorepy/setup.py
    M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py
    M Tools/Scripts/libraries/webkitcorepy/webkitcorepy/call_by_need.py
    M Tools/Scripts/libraries/webkitscmpy/setup.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/commit.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/commit_classifier.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/svn.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/svn.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_git_lfs.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pickable.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/scm.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/svn.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/scm_base.py

  Log Message:
  -----------
  [webkitpy] Avoid autoinstalling libraries in init
https://bugs.webkit.org/show_bug.cgi?id=258366
rdar://111120365

Reviewed by Elliott Williams.

Re-organize webkitscmpy and webkitbugspy to avoid invoking the autoinstaller
in webkitpy's __init__.py.

* Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py:
Lazy-evaluate requests import.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py: Ditto.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/issue.py: Ditto.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/user.py:
Use webkitcorepy instead of six.
* Tools/Scripts/libraries/webkitcorepy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitcorepy/webkitcorepy/call_by_need.py:
(CallByNeed.__getattribute__): Attempt to use underlying object's attributes
when no type is defined.
(CallByNeed.__call__): If the value is callable, call it.
* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/commit.py:
Use webkitcorepy instead of six.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/commit_classifier.py:
(CommitClassifier.LineFilter.fuzzy): Move rapidfuzz import into function call.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
Use webkitcorepy instead of six.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/scm.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:
Move mock import into function call.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/svn.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/svn.py:
Move xmldict import into function call.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_git_lfs.py:
Lazy import requests.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/pickable.py:
(Pickable.Filters.fuzzy): Move rapidfuzz import into function call.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py:
Lazy import requests.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/pull_request.py:
Use webkitcorepy instead of six.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py:
Use webkitcorepy instead of six, lazy import requests.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/scm.py:
Use webkitcorepy instead of six.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/svn.py:
Lazy import requests and xmltodict.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/scm_base.py:
Use webkitcorepy instead of six.

Canonical link: https://commits.webkit.org/265377@main




More information about the webkit-changes mailing list