[webkit-changes] [WebKit/WebKit] 26d746: Refactor enum in WebTouchEvent to enum class

Jessica Cheung noreply at github.com
Wed Jun 21 12:54:11 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 26d7460d3e657de37f47b9d8f587e14ec95c0438
      https://github.com/WebKit/WebKit/commit/26d7460d3e657de37f47b9d8f587e14ec95c0438
  Author: Jessica Cheung <jcheung23 at apple.com>
  Date:   2023-06-21 (Wed, 21 Jun 2023)

  Changed paths:
    M Source/WebKit/Shared/WebEvent.serialization.in
    M Source/WebKit/Shared/WebEventConversion.cpp
    M Source/WebKit/Shared/WebPlatformTouchPoint.cpp
    M Source/WebKit/Shared/WebTouchEvent.cpp
    M Source/WebKit/Shared/WebTouchEvent.h
    M Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm
    R Source/WebKit/Shared/ios/WebPlatformTouchPointIOS.cpp
    M Source/WebKit/Shared/libwpe/WebEventFactory.cpp
    M Source/WebKit/SourcesCocoa.txt
    M Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Refactor enum in WebTouchEvent to enum class
https://bugs.webkit.org/show_bug.cgi?id=257223
rdar://109736930

Reviewed by Wenson Hsieh.

Refactor enum TouchPointState in WebTouchEvent to be enum classes.
Changed TouchPointState to State to reduce redundancy.

* Source/WebKit/Shared/WebEvent.serialization.in:
* Source/WebKit/Shared/WebEventConversion.cpp:
(WebKit::touchEventType):
(WebKit::WebKit2PlatformTouchPoint::WebKit2PlatformTouchPoint):
* Source/WebKit/Shared/WebPlatformTouchPoint.cpp:
(WebKit::WebPlatformTouchPoint::WebPlatformTouchPoint):
(WebKit::WebPlatformTouchPoint::encode const): Deleted.
(WebKit::WebPlatformTouchPoint::decode): Deleted.
* Source/WebKit/Shared/WebTouchEvent.cpp:
(WebKit::WebTouchEvent::allTouchPointsAreReleased const):
* Source/WebKit/Shared/WebTouchEvent.h:
(WebKit::WebPlatformTouchPoint::WebPlatformTouchPoint):
(WebKit::WebPlatformTouchPoint::phase const):
(WebKit::WebPlatformTouchPoint::state const):
(WebKit::WebPlatformTouchPoint::setTouchType):
(WebKit::WebPlatformTouchPoint::touchType const):
(WebKit::WebPlatformTouchPoint::setState):
* Source/WebKit/Shared/ios/NativeWebTouchEventIOS.mm:
(WebKit::convertTouchPhase):
(WebKit::NativeWebTouchEvent::extractWebTouchPoint):
* Source/WebKit/Shared/ios/WebPlatformTouchPointIOS.cpp: Removed.
* Source/WebKit/Shared/libwpe/WebEventFactory.cpp:
(WebKit::stateForTouchPoint):
* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:
(appendTouchEvent):
(touchPointStateForEvents):
(webkitWebViewBaseGetTouchPointsForEvent):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::touchEventTrackingType const):
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _handleTouchActionsForTouchEvent:]):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/265370@main




More information about the webkit-changes mailing list