[webkit-changes] [WebKit/WebKit] 540c18: REGRESSION(259684 at main-259698@main?) [[ Ventura wk...

[Myles C. Maxfield]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 540c18841b4868f0928026ecd56d132ec2e318eb
      https://github.com/WebKit/WebKit/commit/540c18841b4868f0928026ecd56d132ec2e318eb
  Author: Myles C. Maxfield <mmaxfield at apple.com>
  Date:   2023-06-21 (Wed, 21 Jun 2023)

  Changed paths:
    M LayoutTests/platform/mac/TestExpectations
    M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
    M Source/WebCore/PAL/pal/cf/VideoToolboxSoftLink.cpp
    M Source/WebCore/PAL/pal/cf/VideoToolboxSoftLink.h
    A Source/WebCore/PAL/pal/spi/cf/VideoToolboxSPI.h
    M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

  Log Message:
  -----------
  REGRESSION(259684 at main-259698@main?) [[ Ventura wk2 ] fast/images/avif-as-image.html is a constant ImageOnlyFailure
https://bugs.webkit.org/show_bug.cgi?id=256119
rdar://108684696

Reviewed by Per Arne Vollan.

We had code of the form:
```
callIntoWebKitAdditionsToMakeImagesWork();
```

There's no reason for the "make images work" code to be in WebKitAdditions, so this patch
just moves it to WebKit and deletes the USE(APPLE_INTERNAL_SDK) guard. This fixes the images.

* LayoutTests/platform/mac/TestExpectations:
* Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:
* Source/WebCore/PAL/pal/cf/VideoToolboxSoftLink.cpp:
* Source/WebCore/PAL/pal/cf/VideoToolboxSoftLink.h:
* Source/WebCore/PAL/pal/spi/cf/VideoToolboxSPI.h: Added.
* Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::setVideoDecoderBehaviors):
(WebKit::WebProcess::platformInitializeWebProcess):

Canonical link: https://commits.webkit.org/265359@main