[webkit-changes] [WebKit/WebKit] 0449db: Reduce repetitive logging in B3 disassembly

Commit Queue noreply at github.com
Tue Jun 20 15:38:09 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0449dbc56f1de6bd6caf993401539e9f3f2521db
      https://github.com/WebKit/WebKit/commit/0449dbc56f1de6bd6caf993401539e9f3f2521db
  Author: David Degazio <d_degazio at apple.com>
  Date:   2023-06-20 (Tue, 20 Jun 2023)

  Changed paths:
    M Source/JavaScriptCore/ftl/FTLState.cpp
    M Source/JavaScriptCore/wasm/WasmBBQPlan.cpp
    M Source/JavaScriptCore/wasm/WasmOMGPlan.cpp
    M Source/JavaScriptCore/wasm/WasmOSREntryPlan.cpp

  Log Message:
  -----------
  Reduce repetitive logging in B3 disassembly
https://bugs.webkit.org/show_bug.cgi?id=258317
rdar://111057998

Reviewed by Yusuke Suzuki.

When logging B3 disassembly, adds a check to see if the last Air
instruction had the same origin. If it did, we skip logging it
again, to reduce clutter when a B3 value lowers to multiple
consecutive Air instructions.

* Source/JavaScriptCore/ftl/FTLState.cpp:
(JSC::FTL::State::dumpDisassembly):
* Source/JavaScriptCore/wasm/WasmBBQPlan.cpp:
(JSC::Wasm::BBQPlan::dumpDisassembly):
* Source/JavaScriptCore/wasm/WasmOMGPlan.cpp:
(JSC::Wasm::OMGPlan::dumpDisassembly):
* Source/JavaScriptCore/wasm/WasmOSREntryPlan.cpp:
(JSC::Wasm::OSREntryPlan::dumpDisassembly):

Canonical link: https://commits.webkit.org/265338@main




More information about the webkit-changes mailing list