[webkit-changes] [WebKit/WebKit] 62b42f: Changing the dir attribute of documentElement does...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 62b42f584e0a6eeb8adffe59e1ab343e591b090e
      https://github.com/WebKit/WebKit/commit/62b42f584e0a6eeb8adffe59e1ab343e591b090e
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-06-20 (Tue, 20 Jun 2023)

  Changed paths:
    A LayoutTests/fast/css/dir-pseudo-update-document-element-expected.html
    A LayoutTests/fast/css/dir-pseudo-update-document-element.html
    M Source/WebCore/html/HTMLElement.cpp

  Log Message:
  -----------
  Changing the dir attribute of documentElement doesn't update a child element matching :dir pseudo class
https://bugs.webkit.org/show_bug.cgi?id=257133

Reviewed by Antti Koivisto.

The bug was caused by the superfluous condition to not update the effective directionality when
the parent element is the document element. Removed this check to fix the bug.

* LayoutTests/fast/css/dir-pseudo-update-document-element-expected.html: Added.
* LayoutTests/fast/css/dir-pseudo-update-document-element.html: Added.
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::insertedIntoAncestor):

Canonical link: https://commits.webkit.org/265332@main