[webkit-changes] [WebKit/WebKit] 655ad8: REGRESSION(262669 at main): Spelling corrected despit...

Tim Nguyen noreply at github.com
Tue Jun 20 11:29:21 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 655ad809d943553a160ae45fdb0918b12f4f6868
      https://github.com/WebKit/WebKit/commit/655ad809d943553a160ae45fdb0918b12f4f6868
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-06-20 (Tue, 20 Jun 2023)

  Changed paths:
    M Source/WebCore/editing/AlternativeTextController.cpp

  Log Message:
  -----------
  REGRESSION(262669 at main): Spelling corrected despite "Correct spelling automatically" being turned off
https://bugs.webkit.org/show_bug.cgi?id=258305
rdar://110217888

Reviewed by Aditya Keerthi.

NSCorrectionIndicatorTypeDefault & NSCorrectionIndicatorTypeReversion bubbles are associated with autocorrection, and have
the accept on dismiss behavior. Do not show those bubbles when autocorrection is turned off.

Only display NSCorrectionIndicatorTypeGuesses bubbles to match behavior from other apps.

* Source/WebCore/editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::startAlternativeTextUITimer):

Canonical link: https://commits.webkit.org/265330@main




More information about the webkit-changes mailing list