[webkit-changes] [WebKit/WebKit] 901d1f: REGRESSION(263809 at main): [UNIX] SharedMemory::map ...

Carlos Garcia Campos noreply at github.com
Tue Jun 20 10:50:29 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 901d1f8cc477679f97b4cb50685cfec2e1bfa9b3
      https://github.com/WebKit/WebKit/commit/901d1f8cc477679f97b4cb50685cfec2e1bfa9b3
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2023-06-20 (Tue, 20 Jun 2023)

  Changed paths:
    M Source/WebKit/Platform/unix/SharedMemoryUnix.cpp

  Log Message:
  -----------
  REGRESSION(263809 at main): [UNIX] SharedMemory::map is leaking the file descriptor
https://bugs.webkit.org/show_bug.cgi?id=258275

Reviewed by Michael Catanzaro.

Once mapped, we don't need to keep the file descriptor open. Before
263809 at main, we cleared the file descriptor after the mmap call, then
created an instance with -1 as fd. Now we are creating the new instance
with the handle fd moved.

* Source/WebKit/Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::map):

Canonical link: https://commits.webkit.org/265326@main




More information about the webkit-changes mailing list