[webkit-changes] [WebKit/WebKit] 06c5a9: REGRESSION(264826 at main): [GStreamer] Fill informat...

Carlos Garcia Campos noreply at github.com
Mon Jun 19 03:10:47 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 06c5a9867e9b074ec7e24668cec249ff45bc280f
      https://github.com/WebKit/WebKit/commit/06c5a9867e9b074ec7e24668cec249ff45bc280f
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2023-06-19 (Mon, 19 Jun 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/egl/GLContext.cpp
    M Source/WebCore/platform/graphics/egl/GLContext.h
    M Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp

  Log Message:
  -----------
  REGRESSION(264826 at main): [GStreamer] Fill information on the gst GL context
https://bugs.webkit.org/show_bug.cgi?id=258199

Reviewed by Miguel Gomez.

In 264826 at main I removed the activate and fill of the gst GL context,
confused by the API docs of gst_gl_context_fill_info() that says that
it's typically used with wrapped contexts to allow wrapped contexts to
be used as regular GstGLContexts. We don't want it to be used as a
regular context, but the regular context uses the filled information of
the sharing context to get the EGL config.

* Source/WebCore/platform/graphics/egl/GLContext.cpp:
(WebCore::GLContext::unmakeContextCurrent):
(WebCore::GLContext::ScopedGLContextCurrent::ScopedGLContextCurrent):
(WebCore::GLContext::ScopedGLContextCurrent::~ScopedGLContextCurrent):
* Source/WebCore/platform/graphics/egl/GLContext.h:
* Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp:
(WebCore::PlatformDisplay::gstGLContext const):

Canonical link: https://commits.webkit.org/265302@main




More information about the webkit-changes mailing list