[webkit-changes] [WebKit/WebKit] 6954ce: Make ISO parse() methods testable

Commit Queue noreply at github.com
Fri Jun 16 18:03:46 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6954cec8768da448615eb6b380081eb1a27b8d06
      https://github.com/WebKit/WebKit/commit/6954cec8768da448615eb6b380081eb1a27b8d06
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2023-06-16 (Fri, 16 Jun 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/avfoundation/ISOFairPlayStreamingPsshBox.cpp
    M Source/WebCore/platform/graphics/avfoundation/ISOFairPlayStreamingPsshBox.h
    M Source/WebCore/platform/graphics/iso/ISOOriginalFormatBox.cpp
    M Source/WebCore/platform/graphics/iso/ISOOriginalFormatBox.h
    M Source/WebCore/platform/graphics/iso/ISOProtectionSchemeInfoBox.cpp
    M Source/WebCore/platform/graphics/iso/ISOProtectionSchemeInfoBox.h
    M Source/WebCore/platform/graphics/iso/ISOProtectionSystemSpecificHeaderBox.cpp
    M Source/WebCore/platform/graphics/iso/ISOProtectionSystemSpecificHeaderBox.h
    M Source/WebCore/platform/graphics/iso/ISOSchemeInformationBox.cpp
    M Source/WebCore/platform/graphics/iso/ISOSchemeInformationBox.h
    M Source/WebCore/platform/graphics/iso/ISOSchemeTypeBox.cpp
    M Source/WebCore/platform/graphics/iso/ISOSchemeTypeBox.h
    M Source/WebCore/platform/graphics/iso/ISOTrackEncryptionBox.cpp
    M Source/WebCore/platform/graphics/iso/ISOTrackEncryptionBox.h
    M Source/WebCore/platform/graphics/iso/ISOVTTCue.h

  Log Message:
  -----------
  Make ISO parse() methods testable
https://bugs.webkit.org/show_bug.cgi?id=258155

Reviewed by Eric Carlson.

Export constructor, destructor and parse() methods to make them
testable.  If the whole class is exported, implement default
constructor and destructor in the source file.

* Source/WebCore/platform/graphics/avfoundation/ISOFairPlayStreamingPsshBox.cpp:
* Source/WebCore/platform/graphics/avfoundation/ISOFairPlayStreamingPsshBox.h:
* Source/WebCore/platform/graphics/iso/ISOOriginalFormatBox.cpp:
* Source/WebCore/platform/graphics/iso/ISOOriginalFormatBox.h:
* Source/WebCore/platform/graphics/iso/ISOProtectionSchemeInfoBox.cpp:
* Source/WebCore/platform/graphics/iso/ISOProtectionSchemeInfoBox.h:
* Source/WebCore/platform/graphics/iso/ISOProtectionSystemSpecificHeaderBox.cpp:
* Source/WebCore/platform/graphics/iso/ISOProtectionSystemSpecificHeaderBox.h:
* Source/WebCore/platform/graphics/iso/ISOSchemeInformationBox.cpp:
* Source/WebCore/platform/graphics/iso/ISOSchemeInformationBox.h:
* Source/WebCore/platform/graphics/iso/ISOSchemeTypeBox.cpp:
* Source/WebCore/platform/graphics/iso/ISOSchemeTypeBox.h:
* Source/WebCore/platform/graphics/iso/ISOTrackEncryptionBox.cpp:
* Source/WebCore/platform/graphics/iso/ISOTrackEncryptionBox.h:
* Source/WebCore/platform/graphics/iso/ISOVTTCue.h:

Canonical link: https://commits.webkit.org/265263@main




More information about the webkit-changes mailing list