[webkit-changes] [WebKit/WebKit] 9632de: Check CachedResourceLoader's document WeakPtr in m...

[Brent Fulgham]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9632def06c0f39742c6b9b5af8ca7259b44583e8
      https://github.com/WebKit/WebKit/commit/9632def06c0f39742c6b9b5af8ca7259b44583e8
  Author: Brent Fulgham <bfulgham at apple.com>
  Date:   2023-06-16 (Fri, 16 Jun 2023)

  Changed paths:
    M Source/WebCore/loader/cache/CachedResourceLoader.cpp

  Log Message:
  -----------
  Check CachedResourceLoader's document WeakPtr in more places
https://bugs.webkit.org/show_bug.cgi?id=258167
<rdar://106964279>

Reviewed by Chris Dumez.

The CachedResourceLoader class holds a WeakPtr to a Document, which may be
a nullptr at different moments in loading. We inconsistently check for
nullptr, which telemetry shows is triggering some crashes.

This patch provides more rigorous checks for nullptr to avoid these crashes.

* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::cachedResource const):
(WebCore::CachedResourceLoader::checkInsecureContent const):
(WebCore::CachedResourceLoader::allowedByContentSecurityPolicy const):
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::canRequestAfterRedirection const):
(WebCore::CachedResourceLoader::canRequestInContentDispositionAttachmentSandbox const):

Canonical link: https://commits.webkit.org/265259@main