[webkit-changes] [WebKit/WebKit] 5a644c: [GStreamer][WebRTC] Incoming track ID doesn't matc...
Philippe Normand
noreply at github.com
Fri Jun 16 07:00:27 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5a644c4173145039030534b9c3d31d7967ab1da8
https://github.com/WebKit/WebKit/commit/5a644c4173145039030534b9c3d31d7967ab1da8
Author: Philippe Normand <philn at igalia.com>
Date: 2023-06-16 (Fri, 16 Jun 2023)
Changed paths:
M LayoutTests/platform/glib/TestExpectations
M LayoutTests/webrtc/utf8-sdp.html
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.h
M Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpTransceiverBackend.cpp
M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.cpp
Log Message:
-----------
[GStreamer][WebRTC] Incoming track ID doesn't match sender track ID
https://bugs.webkit.org/show_bug.cgi?id=258124
Reviewed by Xabier Rodriguez-Calvar.
The issues here were that we were handling SDP msid attribute values as ascii instead of unicode
encoded in UTF8 and that we were using our sender track ID as receiver (incoming) track ID.
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/webrtc/utf8-sdp.html:
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::addTrack):
(WebCore::GStreamerMediaEndpoint::trackIdFromSDPMedia):
(WebCore::GStreamerMediaEndpoint::addRemoteStream):
(WebCore::GStreamerMediaEndpoint::collectTransceivers):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h:
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.cpp:
(WebCore::GStreamerPeerConnectionBackend::newRemoteTransceiver):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerPeerConnectionBackend.h:
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpTransceiverBackend.cpp:
(WebCore::GStreamerRtpTransceiverBackend::mid):
* Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingMediaSourceGStreamer.cpp:
(WebCore::RealtimeOutgoingMediaSourceGStreamer::allowedCaps const):
(WebCore::RealtimeOutgoingMediaSourceGStreamer::setSource):
Canonical link: https://commits.webkit.org/265244@main
More information about the webkit-changes
mailing list