[webkit-changes] [WebKit/WebKit] 1ddda5: REGRESSION(264515 at main): [GStreamer] Use of WeakPt...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1ddda51c805979ebb13deeebecb12bd2f321f82e
      https://github.com/WebKit/WebKit/commit/1ddda51c805979ebb13deeebecb12bd2f321f82e
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-06-16 (Fri, 16 Jun 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h
    M Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
    M Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.h

  Log Message:
  -----------
  REGRESSION(264515 at main): [GStreamer] Use of WeakPtr for m_player in MediaPlayerPrivateGStreamer looks unsafe
https://bugs.webkit.org/show_bug.cgi?id=258129

Reviewed by Xabier Rodriguez-Calvar.

The player now creates a single media resource loader and shares it with adaptivedemux-spawned
webkit HTTP sources using GstContext.

* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::sourceSetup):
(WebCore::MediaPlayerPrivateGStreamer::handleNeedContextMessage):
* Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
* Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcSetContext):
(webKitWebSrcCreate):
(webKitWebSrcMakeRequest):
(webKitWebSrcSetResourceLoader):
(webKitWebSrcSetReferrer):
(webKitWebSrcSetMediaPlayer): Deleted.
* Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.h:

Canonical link: https://commits.webkit.org/265236@main