[webkit-changes] [WebKit/WebKit] 425744: Fix termination for ApplyStyleCommand::applyRelati...

Chirag Shah noreply at github.com
Thu Jun 15 21:04:01 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4257443adecd96d4b749c44bb898c2eada6d1497
      https://github.com/WebKit/WebKit/commit/4257443adecd96d4b749c44bb898c2eada6d1497
  Author: Chirag M Shah <chirag_m_shah at apple.com>
  Date:   2023-06-15 (Thu, 15 Jun 2023)

  Changed paths:
    A LayoutTests/fast/editing/editing-with-design-mode-crash-expected.txt
    A LayoutTests/fast/editing/editing-with-design-mode-crash.html
    M Source/WebCore/editing/ApplyStyleCommand.cpp

  Log Message:
  -----------
  Fix termination for ApplyStyleCommand::applyRelativeFontStyleChange
https://bugs.webkit.org/show_bug.cgi?id=258145
rdar://110319440

Reviewed by Ryosuke Niwa.

This change fixes applyRelativeFontStyleChange in case where a node is
removed when we try to add a surrounding span, but we cannot add the
node back as removal makes it so that the surrounding span isn't
editable. The fix ensures that we terminate the loop when the node in
question doesn't have any parent.

* LayoutTests/fast/editing/editing-with-design-mode-crash-expected.txt: Added.
* LayoutTests/fast/editing/editing-with-design-mode-crash.html: Added.
* Source/WebCore/editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):

Canonical link: https://commits.webkit.org/265226@main




More information about the webkit-changes mailing list