[webkit-changes] [WebKit/WebKit] 0315de: Make Win32Handle require an explicit copy construc...

Don Olmstead noreply at github.com
Thu Jun 15 11:22:09 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0315de95257defdb7121160cfaf41203487a275c
      https://github.com/WebKit/WebKit/commit/0315de95257defdb7121160cfaf41203487a275c
  Author: Don Olmstead <don.olmstead at sony.com>
  Date:   2023-06-15 (Thu, 15 Jun 2023)

  Changed paths:
    M Source/WTF/wtf/win/Win32Handle.cpp
    M Source/WTF/wtf/win/Win32Handle.h
    M Source/WebKit/NetworkProcess/cache/NetworkCacheDataCurl.cpp
    M Source/WebKit/Platform/IPC/win/ArgumentCodersWin.cpp

  Log Message:
  -----------
  Make Win32Handle require an explicit copy constructor to be copied
https://bugs.webkit.org/show_bug.cgi?id=258105

Reviewed by Kimmo Kinnunen.

Copying Win32Handle is expensive so make sure this isn't done by
accident. Remove `operator=` as a means of copying. Also remove the
`copy` method as well so everything goes through the copy constructor.

* Source/WTF/wtf/win/Win32Handle.cpp:
(WTF::Win32Handle::copy const): Deleted.
* Source/WTF/wtf/win/Win32Handle.h:
* Source/WebKit/NetworkProcess/cache/NetworkCacheDataCurl.cpp:
(WebKit::NetworkCache::Data::tryCreateSharedMemory const):
* Source/WebKit/Platform/IPC/win/ArgumentCodersWin.cpp:
(IPC::ArgumentCoder<Win32Handle>::encode):

Canonical link: https://commits.webkit.org/265203@main




More information about the webkit-changes mailing list