[webkit-changes] [WebKit/WebKit] b6b165: [WGSL] Call graph builder needs to visit call argu...

Tadeu Zagallo noreply at github.com
Wed Jun 14 21:21:50 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b6b1659c168301fe4033ca3b6008f26484d03320
      https://github.com/WebKit/WebKit/commit/b6b1659c168301fe4033ca3b6008f26484d03320
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-06-14 (Wed, 14 Jun 2023)

  Changed paths:
    M Source/WebGPU/WGSL/CallGraph.cpp
    M Source/WebGPU/WGSL/tests/valid/global-used-by-callee.wgsl
    M Source/WebGPU/WGSL/tests/valid/local-constant-trivial.wgsl

  Log Message:
  -----------
  [WGSL] Call graph builder needs to visit call arguments
https://bugs.webkit.org/show_bug.cgi?id=258080
rdar://110783356

Reviewed by Dan Glastonbury.

By not visiting call arguments the call graph was missing calls within calls,
e.g. `f(g())` would fail to add `g()` to the call graph.

* Source/WebGPU/WGSL/CallGraph.cpp:
(WGSL::CallGraphBuilder::visit):
* Source/WebGPU/WGSL/tests/valid/global-used-by-callee.wgsl:
* Source/WebGPU/WGSL/tests/valid/local-constant-trivial.wgsl:

Canonical link: https://commits.webkit.org/265180@main




More information about the webkit-changes mailing list