[webkit-changes] [WebKit/WebKit] 7e2fcf: readAsDataURL.readAsDataURL() is incorrect for emp...

Chris Dumez noreply at github.com
Wed Jun 14 08:07:16 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7e2fcfdc82fa6d96309501c74e857fe7bc273151
      https://github.com/WebKit/WebKit/commit/7e2fcfdc82fa6d96309501c74e857fe7bc273151
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-06-14 (Wed, 14 Jun 2023)

  Changed paths:
    M LayoutTests/fast/files/read-file-async-expected.txt
    M LayoutTests/fast/files/workers/worker-read-file-async-expected.txt
    M LayoutTests/fast/files/workers/worker-read-file-sync-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_readAsDataURL.any-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_readAsDataURL.any.js
    M LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_readAsDataURL.any.worker-expected.txt
    M Source/WebCore/fileapi/FileReaderLoader.cpp

  Log Message:
  -----------
  readAsDataURL.readAsDataURL() is incorrect for empty blobs
https://bugs.webkit.org/show_bug.cgi?id=258043

Reviewed by Darin Adler.

readAsDataURL.readAsDataURL() was incorrect for empty blobs. Our behavior didn't
match Chrome or Firefox and causes us to fail the
FileAPI/reading-data-section/filereader_readAsDataURL.any.html WPT test.

We used to return "data:" instead of "data:application/octet-stream;base64,".

* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_readAsDataURL.any-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/reading-data-section/filereader_readAsDataURL.any.js:
Resync from upstream to gain test coverage and rebaseline.

* Source/WebCore/fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::convertToDataURL):

Canonical link: https://commits.webkit.org/265153@main




More information about the webkit-changes mailing list