[webkit-changes] [WebKit/WebKit] e42840: Fix imported/w3c/web-platform-tests/webcodecs/vide...
youennf
noreply at github.com
Tue Jun 13 23:44:06 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e428405c2a7e87e904e09a8122b3ae9d223b59aa
https://github.com/WebKit/WebKit/commit/e428405c2a7e87e904e09a8122b3ae9d223b59aa
Author: Youenn Fablet <youennf at gmail.com>
Date: 2023-06-13 (Tue, 13 Jun 2023)
Changed paths:
M LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-construction.crossOriginSource.sub-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-construction.crossOriginSource.sub.html
M Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.cpp
M Source/WebCore/html/HTMLImageElement.cpp
M Source/WebCore/svg/SVGImageElement.cpp
Log Message:
-----------
Fix imported/w3c/web-platform-tests/webcodecs/videoFrame-construction.crossOriginSource.sub.html
https://bugs.webkit.org/show_bug.cgi?id=257749
rdar://110322419
Reviewed by Eric Carlson.
Update imported/w3c/web-platform-tests/webcodecs/videoFrame-construction.crossOriginSource.sub.html to work around specificities related to not rendered SVG images.
The specificities are that the load event is not fired when the SVG image is detached from the DOM and that there is no CachedImage if it is not visible.
We should investigate both specificities independently.
Update SVGImageElement::renderingTaintsOrigin to take into account CORS and add a CORS check in the SVG Image to VideoFrame code path.
We move the data URL check after the imge renderingTaintsOrigin check as we should first check whether its content is not tainting and then if its origin would taint or not.
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-construction.crossOriginSource.sub-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-construction.crossOriginSource.sub.html:
* Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.cpp:
(WebCore::checkImageUsability):
* Source/WebCore/html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::originClean const):
* Source/WebCore/svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::renderingTaintsOrigin const):
Canonical link: https://commits.webkit.org/265142@main
More information about the webkit-changes
mailing list