[webkit-changes] [WebKit/WebKit] 139355: Remove SharedMemory::adopt

Don Olmstead noreply at github.com
Tue Jun 13 20:24:57 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 139355b62834b66aeb6f812dfbc05f33a2e7686e
      https://github.com/WebKit/WebKit/commit/139355b62834b66aeb6f812dfbc05f33a2e7686e
  Author: Don Olmstead <don.olmstead at sony.com>
  Date:   2023-06-13 (Tue, 13 Jun 2023)

  Changed paths:
    M Source/WebKit/NetworkProcess/cache/NetworkCacheDataCurl.cpp
    M Source/WebKit/Platform/SharedMemory.h
    M Source/WebKit/Platform/win/SharedMemoryWin.cpp

  Log Message:
  -----------
  Remove SharedMemory::adopt
https://bugs.webkit.org/show_bug.cgi?id=256676

Reviewed by Kimmo Kinnunen and Fujii Hironori.

Use the updated methods in `Win32Handle` to implement
`Data::tryCreateSharedMemory` without directly calling into
`DuplicateHandle`. This code was the only place calling
`SharedMemory::adopt` outside of `SharedMemory.cpp`. Move the contents
of it into `SharedMemory::map` and remove this Window's only method.

* Source/WebKit/NetworkProcess/cache/NetworkCacheDataCurl.cpp:
(WebKit::NetworkCache::Data::tryCreateSharedMemory const):
* Source/WebKit/Platform/SharedMemory.h:
* Source/WebKit/Platform/win/SharedMemoryWin.cpp:
(WebKit::SharedMemory::map):
(WebKit::SharedMemory::adopt): Deleted.

Canonical link: https://commits.webkit.org/265140@main




More information about the webkit-changes mailing list