[webkit-changes] [WebKit/WebKit] 88ce5a: [WGSL] size and align attributes should not genera...

Tadeu Zagallo noreply at github.com
Tue Jun 13 00:36:25 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 88ce5a35673023f55e9d057ee29614583476aa55
      https://github.com/WebKit/WebKit/commit/88ce5a35673023f55e9d057ee29614583476aa55
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-06-13 (Tue, 13 Jun 2023)

  Changed paths:
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
    M Source/WebGPU/WGSL/tests/valid/struct.wgsl

  Log Message:
  -----------
  [WGSL] size and align attributes should not generate code
https://bugs.webkit.org/show_bug.cgi?id=257901
rdar://110539602

Reviewed by Dan Glastonbury.

The default visitor would cause the value of those attributes to be printed,
which result in invalid metal code. To fix it we simply have to override the
visitor with a no-op implementation.

* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):

Canonical link: https://commits.webkit.org/265110@main




More information about the webkit-changes mailing list