[webkit-changes] [WebKit/WebKit] 7e2067: Update implementation of contain flag for motion p...

Nikos Mouchtaris noreply at github.com
Mon Jun 12 23:40:15 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7e206701112298ed0df6f7a8e3a393e9e8531530
      https://github.com/WebKit/WebKit/commit/7e206701112298ed0df6f7a8e3a393e9e8531530
  Author: Nikolaos Mouchtaris <nmouchtaris at apple.com>
  Date:   2023-06-12 (Mon, 12 Jun 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-contain-004.html
    M Source/WebCore/platform/animation/AcceleratedEffectValues.cpp
    M Source/WebCore/rendering/PathOperation.cpp
    M Source/WebCore/rendering/PathOperation.h
    M Source/WebCore/rendering/style/RenderStyle.cpp

  Log Message:
  -----------
  Update implementation of contain flag for motion path <ray>
https://bugs.webkit.org/show_bug.cgi?id=256225
rdar://108861663

Reviewed by Tim Nguyen.

After w3c/fxtf-drafts at bd9fb9b, we need to update our contain
implementation to follow this new behavior. This involves replacing the old implementation
in RayPathOperation::lengthForContainPath to the new behavior, which just bases the length
we shorten the computed path length on half the width or height of the element that we are
animating. Since we no longer need the anchor point or the angle of the ray, remove this
from RayPathOperation::lengthForContainPath's function parameters (as well as all other
PathOperations).

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/css/motion/offset-path-ray-contain-004.html:
* Source/WebCore/platform/animation/AcceleratedEffectValues.cpp:
(WebCore::AcceleratedEffectValues::AcceleratedEffectValues):
* Source/WebCore/rendering/PathOperation.cpp:
(WebCore::RayPathOperation::lengthForContainPath const):
(WebCore::RayPathOperation::getPath const):
* Source/WebCore/rendering/PathOperation.h:
(WebCore::PathOperation::getPath):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::applyMotionPathTransform const):

Canonical link: https://commits.webkit.org/265106@main




More information about the webkit-changes mailing list