[webkit-changes] [WebKit/WebKit] c31366: [GTK] No key modifier present in wheel event

Michael Catanzaro noreply at github.com
Mon Jun 12 23:08:45 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c313668f2cf7dcce30a7bf265f0b363230927323
      https://github.com/WebKit/WebKit/commit/c313668f2cf7dcce30a7bf265f0b363230927323
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2023-06-12 (Mon, 12 Jun 2023)

  Changed paths:
    M Source/WebKit/Shared/WebEvent.h
    M Source/WebKit/Shared/gtk/NativeWebWheelEventGtk.cpp
    M Source/WebKit/Shared/gtk/WebEventFactory.cpp
    M Source/WebKit/Shared/gtk/WebEventFactory.h

  Log Message:
  -----------
  [GTK] No key modifier present in wheel event
https://bugs.webkit.org/show_bug.cgi?id=257910

Reviewed by Carlos Garcia Campos.

Pass the key modifier along with wheel events, rather than dropping it.
Thanks to Elie Donadio for debugging the problem, identifying the code
that needed fixed, and also providing a manual test case to confirm
the result.

This additionally passes along the wall time from the GdkEvent rather
than using current time.

* Source/WebKit/Shared/WebEvent.h:
* Source/WebKit/Shared/gtk/NativeWebWheelEventGtk.cpp:
(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):
* Source/WebKit/Shared/gtk/WebEventFactory.cpp:
(WebKit::WebEventFactory::createWebWheelEvent):
* Source/WebKit/Shared/gtk/WebEventFactory.h:

Canonical link: https://commits.webkit.org/265104@main




More information about the webkit-changes mailing list