[webkit-changes] [WebKit/WebKit] e6bd99: _WKDataTask should complete with error if network ...

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e6bd99d51c88b176612a1a42595956596718c6ca
      https://github.com/WebKit/WebKit/commit/e6bd99d51c88b176612a1a42595956596718c6ca
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-06-12 (Mon, 12 Jun 2023)

  Changed paths:
    M Source/WebKit/UIProcess/API/APIDataTask.cpp
    M Source/WebKit/UIProcess/API/APIDataTask.h
    M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm

  Log Message:
  -----------
  _WKDataTask should complete with error if network process crashes during its creation
https://bugs.webkit.org/show_bug.cgi?id=257991
rdar://110675345

Reviewed by Chris Dumez.

Previously, we would MESSAGE_CHECK and terminate the network process again, and the _WKDataTaskDelegate
would never be informed that an error occurred.  Now we inform the application of an error, like we do
when the network process crashes after it is created, which is already covered by API tests.

* Source/WebKit/UIProcess/API/APIDataTask.cpp:
(API::DataTask::networkProcessCrashed):
* Source/WebKit/UIProcess/API/APIDataTask.h:
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::dataTaskWithRequest):
(WebKit::NetworkProcessProxy::networkProcessDidTerminate):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
(TEST):

Canonical link: https://commits.webkit.org/265096@main