[webkit-changes] [WebKit/WebKit] 1fc9a2: REGRESSION(262585 at main): Potential null dereferenc...

[Said Abou-Hallawa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1fc9a2418bc9fb920b9f7c49b6e9e3963701c3de
      https://github.com/WebKit/WebKit/commit/1fc9a2418bc9fb920b9f7c49b6e9e3963701c3de
  Author: Said Abou-Hallawa <said at apple.com>
  Date:   2023-06-12 (Mon, 12 Jun 2023)

  Changed paths:
    M Source/WebCore/loader/cache/MemoryCache.cpp

  Log Message:
  -----------
  REGRESSION(262585 at main): Potential null dereference of cached images in MemoryCache::destroyDecodedDataForAllImages()
https://bugs.webkit.org/show_bug.cgi?id=257982
rdar://110339514

Reviewed by Chris Dumez.

262585 at main added a call to MemoryCache::destroyDecodedDataForAllImages() when
the cleanup timer fires. This function may try to release the decoded data of an
already deleted CachedImage.

MemoryCache stores the list of cached resources as WeakPtrs. So we need to null
check these WeakPtrs in forEachResource() before using them.

* Source/WebCore/loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::forEachResource):

Canonical link: https://commits.webkit.org/265093@main