[webkit-changes] [WebKit/WebKit] c54345: [IFC] Disable partially trimmable (letter-spacing)...

Alan Baradlay noreply at github.com
Mon Jun 12 16:02:17 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c543451966428cbefa9ba94f6f9ad4e4f9408ed5
      https://github.com/WebKit/WebKit/commit/c543451966428cbefa9ba94f6f9ad4e4f9408ed5
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-06-12 (Mon, 12 Jun 2023)

  Changed paths:
    M Source/WebCore/layout/LayoutState.cpp
    M Source/WebCore/layout/LayoutState.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h

  Log Message:
  -----------
  [IFC] Disable partially trimmable (letter-spacing) content
https://bugs.webkit.org/show_bug.cgi?id=257935

Reviewed by Antti Koivisto.

This is only enabled in the currently non-functional, non-integration codepath.
Let's disable it completely and make it work when we don't feature-match legacy line layout anymore.

* Source/WebCore/layout/LayoutState.cpp:
(WebCore::Layout::LayoutState::shouldIgnoreTrailingLetterSpacing const): Deleted.
* Source/WebCore/layout/LayoutState.h:
* Source/WebCore/layout/formattingContexts/inline/InlineLine.cpp:
(WebCore::Layout::Line::appendTextContent):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::placeInlineAndFloatContent):
(WebCore::Layout::LineCandidate::LineCandidate): Deleted.
(WebCore::Layout::LineCandidate::InlineContent::InlineContent): Deleted.
(WebCore::Layout::LineBuilder::layoutState const): Deleted.
* Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:

Canonical link: https://commits.webkit.org/265090@main




More information about the webkit-changes mailing list