[webkit-changes] [WebKit/WebKit] cbd5d8: REGRESSION (262850 at main): [ iOS, macOS Debug ] Tes...

[Chris Dumez]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cbd5d8089b51367c195902b841af603705a01544
      https://github.com/WebKit/WebKit/commit/cbd5d8089b51367c195902b841af603705a01544
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-06-12 (Mon, 12 Jun 2023)

  Changed paths:
    M Source/WebKit/Platform/IPC/JSIPCBinding.h
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm

  Log Message:
  -----------
  REGRESSION (262850 at main): [ iOS, macOS Debug ] TestWebKitAPI.IPCTestingAPI.CanInterceptHasStorageAccess is a constant failure.
https://bugs.webkit.org/show_bug.cgi?id=255563
rdar://108168809

Reviewed by Alex Christensen.

In 262850 at main, I modified the jsValueForDecodedArgumentValue() taking an
ObjectIdentifier<U> to take an ObjectIdentifierGenericBase instead, in order
to support AtomicObjectIdentifiers as well. However, this broke the API test,
indicating that the wrong jsValueForDecodedArgumentValue() is likely getting
picked now. To address the issue, I am restoring the ObjectIdentifier<U>
overload and introducing a new AtomicObjectIdentifier<U> instead.

* Source/WebKit/Platform/IPC/JSIPCBinding.h:
(IPC::jsValueForDecodedArgumentValue):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm:

Canonical link: https://commits.webkit.org/265087@main