[webkit-changes] [WebKit/WebKit] 2aae66: Null check connection in NetworkRTCProvider::creat...

Alex Christensen noreply at github.com
Mon Jun 12 13:40:47 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2aae66e0482238d21b5990f8c4324f39daedeaff
      https://github.com/WebKit/WebKit/commit/2aae66e0482238d21b5990f8c4324f39daedeaff
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-06-12 (Mon, 12 Jun 2023)

  Changed paths:
    M Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp

  Log Message:
  -----------
  Null check connection in NetworkRTCProvider::createResolver completion handler
https://bugs.webkit.org/show_bug.cgi?id=257975
rdar://110456387

Reviewed by Brent Fulgham.

In 264586 at main I changed Cocoa's WebRTC DNS lookup code to use WebCore::resolveDNS which
calls its completion block even if the DNS response comes after the connection has been
destroyed.  Add a null check and don't send a response through a null connection if this happens.

* Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp:
(WebKit::NetworkRTCProvider::createResolver):

Canonical link: https://commits.webkit.org/265084@main




More information about the webkit-changes mailing list