[webkit-changes] [WebKit/WebKit] 7ce8ae: Add support for printing RenderTree for RemoteFram...

Chirag Shah noreply at github.com
Fri Jun 9 17:35:12 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7ce8aed08237330dbdb86c0c944e2b4ff538fb57
      https://github.com/WebKit/WebKit/commit/7ce8aed08237330dbdb86c0c944e2b4ff538fb57
  Author: Chirag M Shah <chirag_m_shah at apple.com>
  Date:   2023-06-09 (Fri, 09 Jun 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/http/tests/site-isolation/basic-iframe-render-output-expected.txt
    A LayoutTests/http/tests/site-isolation/basic-iframe-render-output.html
    M LayoutTests/platform/mac-wk1/TestExpectations
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
    M Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm
    M Source/WebCore/editing/FrameSelection.cpp
    M Source/WebCore/page/FrameView.h
    M Source/WebCore/page/LocalFrameView.cpp
    M Source/WebCore/page/LocalFrameView.h
    M Source/WebCore/page/RemoteFrame.cpp
    M Source/WebCore/page/RemoteFrame.h
    M Source/WebCore/page/RemoteFrameClient.h
    M Source/WebCore/page/RemoteFrameView.cpp
    M Source/WebCore/page/RemoteFrameView.h
    M Source/WebCore/page/ios/EventHandlerIOS.mm
    M Source/WebCore/page/mac/EventHandlerMac.mm
    M Source/WebCore/platform/Widget.h
    M Source/WebCore/rendering/RenderTreeAsText.cpp
    M Source/WebCore/rendering/RenderTreeAsText.h
    M Source/WebCore/rendering/RenderWidget.cpp
    M Source/WebKit/Scripts/webkit/messages.py
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/UIProcess/WebProcessProxy.cpp
    M Source/WebKit/UIProcess/WebProcessProxy.h
    M Source/WebKit/UIProcess/WebProcessProxy.messages.in
    M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.h
    M Source/WebKit/WebProcess/WebProcess.cpp
    M Source/WebKit/WebProcess/WebProcess.h
    M Source/WebKit/WebProcess/WebProcess.messages.in

  Log Message:
  -----------
  Add support for printing RenderTree for RemoteFrame(s)
https://bugs.webkit.org/show_bug.cgi?id=256972
rdar://105023551

Reviewed by Alex Christensen.

This change adds infrastructure so that we can get RenderTree dumps for
RemoteFrame's which are not hosted in the process which gets the request
to print the RenderTreeAsText

* LayoutTests/http/tests/site-isolation/basic-iframe-render-output-expected.txt: Added.
* LayoutTests/http/tests/site-isolation/basic-iframe-render-output.html: Added.
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::elementAccessibilityHitTest const):
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::addAttachmentChildren):
* Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::accessibilityIgnoreAttachment const):
* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::isFrameElement):
* Source/WebCore/page/FrameView.h:
(isType):
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::writeRenderTreeAsText):
* Source/WebCore/page/LocalFrameView.h:
(isType):
* Source/WebCore/page/RemoteFrame.cpp:
(WebCore::RemoteFrame::renderTreeAsText):
* Source/WebCore/page/RemoteFrame.h:
* Source/WebCore/page/RemoteFrameClient.h:
* Source/WebCore/page/RemoteFrameView.cpp:
(WebCore::RemoteFrameView::writeRenderTreeAsText):
* Source/WebCore/page/RemoteFrameView.h:
* Source/WebCore/page/ios/EventHandlerIOS.mm:
(WebCore::EventHandler::passSubframeEventToSubframe):
* Source/WebCore/page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passSubframeEventToSubframe):
(WebCore::EventHandler::platformCompletePlatformWidgetWheelEvent):
* Source/WebCore/platform/Widget.h:
(WebCore::Widget::isLocalFrameView const):
(WebCore::Widget::isFrameView const): Deleted.
* Source/WebCore/rendering/RenderTreeAsText.cpp:
(WebCore::write):
(WebCore::externalRepresentationForLocalFrame):
* Source/WebCore/rendering/RenderTreeAsText.h:
(WebCore::externalRepresentationForLocalFrame):
* Source/WebCore/rendering/RenderWidget.cpp:
(WebCore::RenderWidget::updateWidgetGeometry):
* Source/WebKit/Scripts/webkit/messages.py:
(headers_for_type):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::renderTreeAsText):
* Source/WebKit/UIProcess/WebProcessProxy.h:
* Source/WebKit/UIProcess/WebProcessProxy.messages.in:
* Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.cpp:
(WebKit::WebRemoteFrameClient::renderTreeAsText):
* Source/WebKit/WebProcess/WebCoreSupport/WebRemoteFrameClient.h:
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveSyncMessage):
(WebKit::WebProcess::renderTreeAsText):
* Source/WebKit/WebProcess/WebProcess.h:
* Source/WebKit/WebProcess/WebProcess.messages.in:

Canonical link: https://commits.webkit.org/265046@main




More information about the webkit-changes mailing list