[webkit-changes] [WebKit/WebKit] 43f29b: Rename SubframePageProxy to RemotePageProxy

Alex Christensen noreply at github.com
Fri Jun 9 16:21:12 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 43f29b75ce2e75cc9f603e84fb04388a206fece3
      https://github.com/WebKit/WebKit/commit/43f29b75ce2e75cc9f603e84fb04388a206fece3
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-06-09 (Fri, 09 Jun 2023)

  Changed paths:
    M Source/WebKit/Sources.txt
    M Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp
    M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm
    A Source/WebKit/UIProcess/RemotePageProxy.cpp
    A Source/WebKit/UIProcess/RemotePageProxy.h
    R Source/WebKit/UIProcess/SubframePageProxy.cpp
    R Source/WebKit/UIProcess/SubframePageProxy.h
    M Source/WebKit/UIProcess/WebFrameProxy.cpp
    M Source/WebKit/UIProcess/WebFrameProxy.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/WebPageProxyInternals.h
    M Source/WebKit/UIProcess/WebProcessPool.cpp
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Rename SubframePageProxy to RemotePageProxy
https://bugs.webkit.org/show_bug.cgi?id=257916
rdar://110550953

Reviewed by J Pascoe.

A RemotePageProxy is the UI process object paired with a WebPage with a RemoteFrame as its main frame.
It has been only used for pages with local subframes, so I initially called it SubframePageProxy because
it communicates with the processes containing subframes.  However, with site isolated pages from window.open,
the name no longer reflects how it will be used.  This rename does not change any behavior.

* Source/WebKit/Sources.txt:
* Source/WebKit/UIProcess/ProvisionalFrameProxy.cpp:
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
* Source/WebKit/UIProcess/RemotePageProxy.cpp: Renamed from Source/WebKit/UIProcess/SubframePageProxy.cpp.
(WebKit::RemotePageProxy::RemotePageProxy):
(WebKit::RemotePageProxy::~RemotePageProxy):
(WebKit::RemotePageProxy::messageSenderConnection const):
(WebKit::RemotePageProxy::messageSenderDestinationID const):
(WebKit::RemotePageProxy::didReceiveMessage):
(WebKit::RemotePageProxy::decidePolicyForResponse):
(WebKit::RemotePageProxy::didCommitLoadForFrame):
(WebKit::RemotePageProxy::didReceiveSyncMessage):
* Source/WebKit/UIProcess/RemotePageProxy.h: Renamed from Source/WebKit/UIProcess/SubframePageProxy.h.
(WebKit::RemotePageProxy::create):
(WebKit::RemotePageProxy::process):
* Source/WebKit/UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::commitProvisionalFrame):
(WebKit::WebFrameProxy::setRemotePageProxy):
(WebKit::WebFrameProxy::setSubframePageProxy): Deleted.
* Source/WebKit/UIProcess/WebFrameProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getAllFrameTrees):
(WebKit::WebPageProxy::updateRemoteFrameSize):
(WebKit::WebPageProxy::createRemoteSubframesInOtherProcesses):
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::callAfterNextPresentationUpdate):
(WebKit::WebPageProxy::addRemotePageProxy):
(WebKit::WebPageProxy::removeRemotePageProxy):
(WebKit::WebPageProxy::remotePageProxyForRegistrableDomain const):
(WebKit::WebPageProxy::addSubframePageProxy): Deleted.
(WebKit::WebPageProxy::removeSubpageFrameProxy): Deleted.
(WebKit::WebPageProxy::subpageFrameProxyForRegistrableDomain const): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxyInternals.h:
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigation):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/265041@main




More information about the webkit-changes mailing list