[webkit-changes] [WebKit/WebKit] 6a68b0: Remove iOS-only NSUserDefaults-backed UA override

[Abrar Rahman Protyasha]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6a68b0c65d6c2504c8455ce9f88b870fb4d6ed94
      https://github.com/WebKit/WebKit/commit/6a68b0c65d6c2504c8455ce9f88b870fb4d6ed94
  Author: Abrar Rahman Protyasha <a_protyasha at apple.com>
  Date:   2023-06-09 (Fri, 09 Jun 2023)

  Changed paths:
    M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp
    M Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h
    M Source/WebCore/platform/ios/UserAgentIOS.mm

  Log Message:
  -----------
  Remove iOS-only NSUserDefaults-backed UA override
https://bugs.webkit.org/show_bug.cgi?id=217927
rdar://70699433

Reviewed by Tim Horton.

This commit relegates the mechanism that reads an override UA from the
NSUserDefault [com.apple.WebFoundation UserAgent] behind a
linked-on-or-after check for its namesake SDKAlignedBehavior.

We do this because the NSUserDefaults-backed UA string is incompatible
with the modern need to compose the UA. Instead, we strongly prefer that
clients use existing API to set the application name (or UA).

* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.cpp:
(WTF::computeSDKAlignedBehaviors):
* Source/WTF/wtf/cocoa/RuntimeApplicationChecksCocoa.h:
* Source/WebCore/platform/ios/UserAgentIOS.mm:
(WebCore::standardUserAgentWithApplicationName):

Canonical link: https://commits.webkit.org/265034@main