[webkit-changes] [WebKit/WebKit] 644d65: Highlight appears behind dictated text

[mwyrzykowski]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 644d6535804c8d7a1ad1204e4203ba2462acf0a8
      https://github.com/WebKit/WebKit/commit/644d6535804c8d7a1ad1204e4203ba2462acf0a8
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2023-06-09 (Fri, 09 Jun 2023)

  Changed paths:
    M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
    M Source/WebKit/UIProcess/mac/WebViewImpl.mm

  Log Message:
  -----------
  Highlight appears behind dictated text
https://bugs.webkit.org/show_bug.cgi?id=257874
radar://110492195

Reviewed by Aditya Keerthi.

264903 at main introduced a regression where the following code:

  auto initialUnderlines = extractInitialUnderlines(string);
  underlines = !initialUnderlines.isEmpty() ? initialUnderlines : extractUnderlines(string);

was changed to:
  underlines = compositionUnderlines(string);

but compositionUnderlines doesn't populate the underlines when they are otherwise empty.

Re-introduce code removed from 264903 at main and this issue appears resolved.

* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration setAllowsInlinePredictions:]):
(-[WKWebViewConfiguration allowsInlinePredictions]):
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::extractUnderlines):
(WebKit::WebViewImpl::setMarkedText):

Canonical link: https://commits.webkit.org/265031@main