[webkit-changes] [WebKit/WebKit] cfe917: [GTK] Remove support for OpenGL API in the web pro...

Carlos Garcia Campos noreply at github.com
Fri Jun 9 06:14:29 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cfe917fec45bf72c371087ece034feee8454f1b4
      https://github.com/WebKit/WebKit/commit/cfe917fec45bf72c371087ece034feee8454f1b4
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2023-06-09 (Fri, 09 Jun 2023)

  Changed paths:
    M Source/ThirdParty/ANGLE/PlatformGTK.cmake
    M Source/ThirdParty/ANGLE/PlatformWPE.cmake
    M Source/WebCore/CMakeLists.txt
    M Source/WebCore/Headers.cmake
    M Source/WebCore/PlatformWin.cmake
    M Source/WebCore/html/canvas/WebGLVertexArrayObject.cpp
    M Source/WebCore/platform/cocoa/CoreVideoSoftLink.cpp
    M Source/WebCore/platform/cocoa/CoreVideoSoftLink.h
    R Source/WebCore/platform/graphics/OpenGLESShims.h
    R Source/WebCore/platform/graphics/OpenGLShims.cpp
    R Source/WebCore/platform/graphics/OpenGLShims.h
    M Source/WebCore/platform/graphics/egl/GLContext.cpp
    M Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp
    R Source/WebCore/platform/graphics/opengl/TemporaryOpenGLSetting.cpp
    R Source/WebCore/platform/graphics/opengl/TemporaryOpenGLSetting.h
    M Source/WebCore/platform/graphics/texmap/TextureMapperContextAttributes.cpp
    M Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp
    M Source/WebCore/platform/graphics/texmap/TextureMapperGLHeaders.h
    M Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp
    M Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp
    M Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp
    M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp
    M Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp
    M Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp
    M Source/WebKit/WebProcess/WebPage/gtk/AcceleratedSurfaceDMABuf.cpp
    M Source/cmake/OptionsGTK.cmake
    M Source/cmake/OptionsPlayStation.cmake
    M Source/cmake/OptionsWPE.cmake
    M Source/cmake/OptionsWin.cmake

  Log Message:
  -----------
  [GTK] Remove support for OpenGL API in the web process
https://bugs.webkit.org/show_bug.cgi?id=257648

Reviewed by Miguel Gomez.

We don't really need to keep supporting OpenGL API in the web process.
The GTK port is the only one still supporting it, so can we remove another
different code path compared to other ports. We use OpenGL ES
unconditionally in the web process, and whatever GTK uses by default in
the UI process.

* Source/ThirdParty/ANGLE/PlatformGTK.cmake: Remove the USE_OPENGL case.
* Source/ThirdParty/ANGLE/PlatformWPE.cmake: Ditto.
* Source/WebCore/CMakeLists.txt: Remove TemporaryOpenGLSetting.cpp from compilation.
* Source/WebCore/Headers.cmake: Remove deleted headers.
* Source/WebCore/PlatformWin.cmake: Remove TemporaryOpenGLSetting.cpp from compilation.
* Source/WebCore/html/canvas/WebGLVertexArrayObject.cpp:
(WebCore::WebGLVertexArrayObject::WebGLVertexArrayObject): Remove OPENGL_ES ifdef that was left after 230256 at main.
* Source/WebCore/platform/cocoa/CoreVideoSoftLink.cpp: Ditto.
* Source/WebCore/platform/cocoa/CoreVideoSoftLink.h: Ditto.
* Source/WebCore/platform/graphics/OpenGLESShims.h: Removed.
* Source/WebCore/platform/graphics/OpenGLShims.cpp: Removed.
* Source/WebCore/platform/graphics/OpenGLShims.h: Removed.
* Source/WebCore/platform/graphics/egl/GLContext.cpp:
(WebCore::GLContext::getEGLConfig): Remove OPENGL_ES ifdefs.
(WebCore::GLContext::create): Ditto.
(WebCore::GLContext::createOffscreen): Ditto.
(WebCore::GLContext::createSharing): Ditto.
(WebCore::GLContext::createContextForEGLVersion): Ditto.
(WebCore::initializeOpenGLShimsIfNeeded): Deleted.
* Source/WebCore/platform/graphics/gstreamer/PlatformDisplayGStreamer.cpp:
(WebCore::PlatformDisplay::gstGLContext const): Remove OPENGL_ES ifdefs.
* Source/WebCore/platform/graphics/opengl/TemporaryOpenGLSetting.cpp: Removed.
* Source/WebCore/platform/graphics/opengl/TemporaryOpenGLSetting.h: Removed.
* Source/WebCore/platform/graphics/texmap/TextureMapperContextAttributes.cpp:
(WebCore::TextureMapperContextAttributes::get): Remove OPENGL_ES ifdefs.
* Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGLData::~TextureMapperGLData): Remove OPENGL_ES ifdefs.
(WebCore::TextureMapperGLData::getVAO): Ditto.
(WebCore::TextureMapperGL::beginPainting): Ditto.
(WebCore::TextureMapperGL::endPainting): Ditto.
* Source/WebCore/platform/graphics/texmap/TextureMapperGLHeaders.h:
* Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:
(WebCore::TextureMapperShaderProgram::create): Remove OPENGL_ES ifdefs.
* Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
* Source/WebKit/UIProcess/API/glib/WebKitProtocolHandler.cpp:
(WebKit::WebKitProtocolHandler::handleGPU): Use the current context to fill EGL info for the UI process.
* Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreDMABuf.cpp:
(WebKit::AcceleratedBackingStoreDMABuf::ensureGLContext): Remove OPENGL_ES ifdef.
* Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:
(WebKit::tryInitializeEGL): Use libepoxy to check required extensions.
(WebKit::AcceleratedBackingStoreWayland::ensureGLContext): Remove OPENGL_ES ifdef.
(WebKit::isEGLImageAvailable): Deleted.
* Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsPlayStation.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/OptionsWin.cmake:

Canonical link: https://commits.webkit.org/265017@main




More information about the webkit-changes mailing list