[webkit-changes] [WebKit/WebKit] ed49f5: [FFC] Do not use RenderFlexibleBox::computeFlexIte...

Alan Baradlay noreply at github.com
Thu Jun 8 21:01:15 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ed49f568ab6bba11437e57c1d876f2e6f82bb6be
      https://github.com/WebKit/WebKit/commit/ed49f568ab6bba11437e57c1d876f2e6f82bb6be
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-06-08 (Thu, 08 Jun 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
    M Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp
    M Source/WebCore/rendering/RenderFlexibleBox.cpp

  Log Message:
  -----------
  [FFC] Do not use RenderFlexibleBox::computeFlexItemMinMaxSizes to compute min/max sizes
https://bugs.webkit.org/show_bug.cgi?id=257856

Reviewed by Antti Koivisto.

Not sure what it is used for in RenderFlexibleBox, but it clearly does not return a max value for most cases (returns infinite instead).
This patch also enables auto width handling (previously the width value came from flex item pre-layouts).

* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::convertFlexItemsToLogicalSpace):
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutUsingFlexFormattingContext):

Canonical link: https://commits.webkit.org/265010@main




More information about the webkit-changes mailing list