[webkit-changes] [WebKit/WebKit] 5627dd: [JSC] Make LazyFireDetail well-scoped

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5627dd004eef5b96f392df69abf661fd95998780
      https://github.com/WebKit/WebKit/commit/5627dd004eef5b96f392df69abf661fd95998780
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-06-08 (Thu, 08 Jun 2023)

  Changed paths:
    M Source/JavaScriptCore/bytecode/Watchpoint.h
    M Source/JavaScriptCore/dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp
    M Source/JavaScriptCore/dfg/DFGAdaptiveStructureWatchpoint.cpp

  Log Message:
  -----------
  [JSC] Make LazyFireDetail well-scoped
https://bugs.webkit.org/show_bug.cgi?id=257846
rdar://110449200

Reviewed by Mark Lam.

LazyFireDetail's scoped lambda has stale references since its scope is already finished.
So this is wrong, but this is only used when debugging flag is enabled. But this causes
some crashes when we use dumpDisassembly etc. options. This patch fixes it by creating
and keeping scoped lambda at the right scope.

* Source/JavaScriptCore/bytecode/Watchpoint.h:
* Source/JavaScriptCore/dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp:
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::handleFire):
* Source/JavaScriptCore/dfg/DFGAdaptiveStructureWatchpoint.cpp:
(JSC::DFG::AdaptiveStructureWatchpoint::fireInternal):

Canonical link: https://commits.webkit.org/264987@main