[webkit-changes] [WebKit/WebKit] 72da1b: [iOS] Set `-[VKCImageAnalyzerRequest imageSource]`...

Wenson Hsieh noreply at github.com
Wed Jun 7 23:11:08 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 72da1b34cd3a5c20f588514272d25140bbd94ff7
      https://github.com/WebKit/WebKit/commit/72da1b34cd3a5c20f588514272d25140bbd94ff7
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-06-07 (Wed, 07 Jun 2023)

  Changed paths:
    M Source/WebCore/PAL/pal/spi/cocoa/VisionKitCoreSPI.h
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  [iOS] Set `-[VKCImageAnalyzerRequest imageSource]` when performing image analysis on paused videos
https://bugs.webkit.org/show_bug.cgi?id=257844
rdar://109173247

Reviewed by Aditya Keerthi.

Set the `-imageSource` flag to `VKImageAnalyzerRequestImageSourceVideoFrame` when triggering image
analysis on iOS over paused videos, to help improve analytics for visual look up and object
detection; no change in behavior, otherwise.

* Source/WebCore/PAL/pal/spi/cocoa/VisionKitCoreSPI.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView imageAnalysisGestureDidBegin:]):
(-[WKContentView _completeImageAnalysisRequestForContextMenu:requestIdentifier:hasTextResults:]):
(-[WKContentView imageAnalysisGestureDidTimeOut:]):
(-[WKContentView beginTextRecognitionForFullscreenVideo:playerViewController:]):
(-[WKContentView beginTextRecognitionForVideoInElementFullscreen:bounds:]):

Canonical link: https://commits.webkit.org/264976@main




More information about the webkit-changes mailing list