[webkit-changes] [WebKit/WebKit] 2ef685: [WebXR] Use WebCore type for framebuffer size.
Dan Glastonbury
noreply at github.com
Wed Jun 7 17:05:09 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2ef6856abf7b164414faa05f88d511caf7913e8c
https://github.com/WebKit/WebKit/commit/2ef6856abf7b164414faa05f88d511caf7913e8c
Author: Dan Glastonbury <djg at apple.com>
Date: 2023-06-07 (Wed, 07 Jun 2023)
Changed paths:
M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp
M Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.h
M Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp
Log Message:
-----------
[WebXR] Use WebCore type for framebuffer size.
https://bugs.webkit.org/show_bug.cgi?id=257781
rdar://problem/110377022
Reviewed by Kimmo Kinnunen.
WebXRWebGLLayer converts the IntSize representing the framebuffer dimensions
into seperate width and height values, as well as converting signed to unsigned
integer, when scaling the dimensions to accommodate DPI.
This patch uses the WebCore type IntSize to store the framebuffer dimensions
instead of separate width & height and keeps the values as signed integers.
* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:
(WebCore::WebXROpaqueFramebuffer::create):
(WebCore::WebXROpaqueFramebuffer::WebXROpaqueFramebuffer):
(WebCore::WebXROpaqueFramebuffer::startFrame):
(WebCore::WebXROpaqueFramebuffer::endFrame):
(WebCore::WebXROpaqueFramebuffer::setupFramebuffer):
(WebCore::WebXROpaqueFramebuffer::allocateRenderbufferStorage):
(WebCore::WebXROpaqueFramebuffer::allocateColorStorage):
(WebCore::WebXROpaqueFramebuffer::allocateDepthStencilStorage):
* Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.h:
(WebCore::WebXROpaqueFramebuffer::width const):
(WebCore::WebXROpaqueFramebuffer::height const):
* Source/WebCore/Modules/webxr/WebXRWebGLLayer.cpp:
(WebCore::createOpaqueFramebuffer):
Canonical link: https://commits.webkit.org/264966@main
More information about the webkit-changes
mailing list