[webkit-changes] [WebKit/WebKit] b4bbe3: AX: AXObjectCache::setIsolatedTreeFocusedObject sh...

AndresGonzalezApple noreply at github.com
Wed Jun 7 12:25:36 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b4bbe36cdab2afbefd487727b429c52598495807
      https://github.com/WebKit/WebKit/commit/b4bbe36cdab2afbefd487727b429c52598495807
  Author: Andres Gonzalez <andresg_22 at apple.com>
  Date:   2023-06-07 (Wed, 07 Jun 2023)

  Changed paths:
    A LayoutTests/accessibility/active-descendant-changes-result-in-focus-changes-expected.txt
    A LayoutTests/accessibility/active-descendant-changes-result-in-focus-changes.html
    M Source/WebCore/accessibility/AXObjectCache.cpp
    M Source/WebCore/accessibility/AXObjectCache.h

  Log Message:
  -----------
  AX: AXObjectCache::setIsolatedTreeFocusedObject should handle the same special cases as focusedObjectForPage.
https://bugs.webkit.org/show_bug.cgi?id=257739
<rdar://problem/110292074>

Reviewed by Chris Fleizach and Tyler Wilcock.

Added AXObjectCache::focusedObjectForNode to handle the special cases for both focusedObjectForPage and setIsolatedTreeFocusedObject. This makes getting the focused object more consistent between ITM on and off. It will also allow to get the focused Object from the Isolated tree without hitting the main thread.

* LayoutTests/accessibility/active-descendant-changes-result-in-focus-changes-expected.txt: Added.
* LayoutTests/accessibility/active-descendant-changes-result-in-focus-changes.html: Added.
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedObjectForPage):
(WebCore::AXObjectCache::focusedObjectForNode):
(WebCore::AXObjectCache::setIsolatedTreeFocusedObject):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):
(WebCore::AXObjectCache::handleActiveDescendantChanged):
* Source/WebCore/accessibility/AXObjectCache.h:

Canonical link: https://commits.webkit.org/264952@main




More information about the webkit-changes mailing list