[webkit-changes] [WebKit/WebKit] 580bf6: REGRESSION (264795 at main) Twitter.com: Video blank/...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 580bf6c28d2b381a9a51fb66f54c445bc51d967d
      https://github.com/WebKit/WebKit/commit/580bf6c28d2b381a9a51fb66f54c445bc51d967d
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-06-07 (Wed, 07 Jun 2023)

  Changed paths:
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h
    M Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
    M Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm

  Log Message:
  -----------
  REGRESSION (264795 at main) Twitter.com: Video blank/black while scrolling
https://bugs.webkit.org/show_bug.cgi?id=257805
rdar://110320059

Reviewed by Eric Carlson.

Use videoInlineSize() rather than presentationSize() to determine whether or not a layer should
be created in MediaPlayerPrivateMediaSourceAVFObjC. And to ensure the layer does get created when
videoInlineSize() changes, override setVideoInlineSizeFenced() in that class, and call it from
RemoteMediaPlayerProxy::setVideoInlineSizeFenced().

* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
* Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::shouldEnsureLayer const):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVideoInlineSizeFenced):
* Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm:
(WebKit::RemoteMediaPlayerProxy::setVideoInlineSizeFenced):

Canonical link: https://commits.webkit.org/264949@main