[webkit-changes] [WebKit/WebKit] b44aa5: Make IPC::Connection::Handle move-only.
mattwoodrow
noreply at github.com
Wed Jun 7 00:36:10 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b44aa50aceaea3c7b7e4cf783c43ed93e4a4047d
https://github.com/WebKit/WebKit/commit/b44aa50aceaea3c7b7e4cf783c43ed93e4a4047d
Author: Matt Woodrow <mattwoodrow at apple.com>
Date: 2023-06-07 (Wed, 07 Jun 2023)
Changed paths:
M Source/WebKit/Platform/IPC/Connection.cpp
M Source/WebKit/Platform/IPC/Connection.h
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp
M Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp
M Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp
M Source/WebKit/WebProcess/Network/NetworkProcessConnectionInfo.h
M Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp
M Tools/TestWebKitAPI/Tests/IPC/IPCTestUtilities.cpp
Log Message:
-----------
Make IPC::Connection::Handle move-only.
https://bugs.webkit.org/show_bug.cgi?id=257579
Reviewed by Dan Glastonbury.
Connection::Handle represents a way to construct the remote end of a connection, and its lifetime controls disconnection messages being sent to the local end.
We shouldn't ever want to copy these, only one remote end can be constructed.
t show
* Source/WebKit/Platform/IPC/Connection.cpp:
(IPC::Connection::Handle::encode):
(IPC::Connection::Handle::decode):
* Source/WebKit/Platform/IPC/Connection.h:
(IPC::Connection::Handle::Handle):
(IPC::Connection::Handle::operator bool const):
(IPC::Connection::Identifier::Identifier):
(IPC::Connection::Identifier::operator bool const):
* Source/WebKit/Scripts/webkit/messages.py:
(types_that_must_be_moved):
* Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::getNetworkProcessConnection):
* Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:
(WebKit::GPUProcessConnection::create):
* Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp:
(WebKit::WebInspectorUI::updateConnection):
* Source/WebKit/WebProcess/Network/NetworkProcessConnectionInfo.h:
(WebKit::NetworkProcessConnectionInfo::encode):
(WebKit::NetworkProcessConnectionInfo::encode const): Deleted.
* Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp:
(TestWebKitAPI::MockTestMessageWithConnection::arguments):
(TestWebKitAPI::MockTestMessageWithConnection::MockTestMessageWithConnection):
(TestWebKitAPI::TEST_F):
(TestWebKitAPI::TEST_P):
* Tools/TestWebKitAPI/Tests/IPC/IPCTestUtilities.cpp:
(TestWebKitAPI::ConnectionTestBase::setupBase):
Canonical link: https://commits.webkit.org/264928@main
More information about the webkit-changes
mailing list