[webkit-changes] [WebKit/WebKit] 8a8e75: [JSC] Use allocated scratch FPR for ARM64 countPop...

Yusuke Suzuki noreply at github.com
Tue Jun 6 13:08:19 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8a8e7575601057b02891fee4723fd3123a161500
      https://github.com/WebKit/WebKit/commit/8a8e7575601057b02891fee4723fd3123a161500
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-06-06 (Tue, 06 Jun 2023)

  Changed paths:
    M Source/JavaScriptCore/assembler/MacroAssemblerARM64.h
    M Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h
    M Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h
    M Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h
    M Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp
    M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp

  Log Message:
  -----------
  [JSC] Use allocated scratch FPR for ARM64 countPopulation
https://bugs.webkit.org/show_bug.cgi?id=257753
rdar://110327985

Reviewed by Justin Michaud.

fpTempRegister is not available in Air, so we should not use it in ARM64 countPopulation implementation.
This patch explicitly allocates FPR scratch register to use it in ARM64 countPopulation.

* Source/JavaScriptCore/assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::countPopulation32):
(JSC::MacroAssemblerARM64::countPopulation64):
* Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::countPopulation32):
* Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h:
(JSC::Wasm::ExpressionType>::addI32Popcnt):
(JSC::Wasm::ExpressionType>::addI64Popcnt):
* Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::addI32Popcnt):
(JSC::Wasm::B3IRGenerator::addI64Popcnt):
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJIT::addI32Popcnt):
(JSC::Wasm::BBQJIT::addI64Popcnt):

Canonical link: https://commits.webkit.org/264907@main




More information about the webkit-changes mailing list