[webkit-changes] [WebKit/WebKit] 0c989a: Upstream inline text predictions support for WebKit
Richard Robinson
noreply at github.com
Tue Jun 6 10:09:26 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0c989ac562785c6fb59dd5698f926822101141a7
https://github.com/WebKit/WebKit/commit/0c989ac562785c6fb59dd5698f926822101141a7
Author: Richard Robinson <richard_robinson2 at apple.com>
Date: 2023-06-06 (Tue, 06 Jun 2023)
Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WTF/wtf/PlatformHave.h
M Source/WebCore/PAL/pal/spi/mac/NSSpellCheckerSPI.h
M Source/WebCore/loader/EmptyClients.cpp
M Source/WebCore/page/EditorClient.h
M Source/WebCore/page/Page.cpp
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
M Source/WebKit/UIProcess/PageClient.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
M Source/WebKit/UIProcess/mac/PageClientImplMac.h
M Source/WebKit/UIProcess/mac/PageClientImplMac.mm
M Source/WebKit/UIProcess/mac/ViewGestureControllerMac.mm
M Source/WebKit/UIProcess/mac/WebViewImpl.h
M Source/WebKit/UIProcess/mac/WebViewImpl.mm
M Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.h
M Source/WebKit/WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm
M Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.h
Log Message:
-----------
Upstream inline text predictions support for WebKit
https://bugs.webkit.org/show_bug.cgi?id=257727
rdar://110220145
Reviewed by Aditya Keerthi.
Upstream support for system inline text predictions in WebKit.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/loader/EmptyClients.cpp:
* Source/WebCore/page/EditorClient.h:
* Source/WebCore/page/Page.cpp:
(WebCore::Page::willBeginScrolling):
(WebCore::Page::didFinishScrolling):
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _setMarkedTextInputEnabled:]):
(-[WKWebViewConfiguration _markedTextInputEnabled]):
(-[WKWebViewConfiguration setAllowsInlinePredictions:]):
(-[WKWebViewConfiguration allowsInlinePredictions]):
* Source/WebKit/UIProcess/PageClient.h:
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setCaretDecorationVisibility): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(shouldUseHighlightsForMarkedText):
(extractUnderlines):
(-[WKContentView setAttributedMarkedText:selectedRange:]):
(-[WKContentView setMarkedText:selectedRange:]):
(-[WKContentView _updateTextInputTraits:]):
(-[WKContentView _updateAdditionalTextInputTraits:]): Deleted.
* Source/WebKit/UIProcess/mac/PageClientImplMac.h:
* Source/WebKit/UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::setCaretDecorationVisibility): Deleted.
* Source/WebKit/UIProcess/mac/ViewGestureControllerMac.mm:
(WebKit::ViewGestureController::handleMagnificationGestureEvent):
* Source/WebKit/UIProcess/mac/WebViewImpl.h:
* Source/WebKit/UIProcess/mac/WebViewImpl.mm:
(WebKit::WebViewImpl::getTextCheckingTypes const):
(WebKit::WebViewImpl::handleRequestedCandidates):
(WebKit::compositionUnderlines):
(WebKit::WebViewImpl::setMarkedText):
(WebKit::WebViewImpl::allowsInlinePredictions const):
(WebKit::WebViewImpl::showInlinePredictionsForCandidate):
(WebKit::WebViewImpl::showInlinePredictionsForCandidates):
(WebKit::WebViewImpl::shouldRequestCandidates const):
(WebKit::extractInitialUnderlines): Deleted.
(WebKit::WebViewImpl::markedTextInputEnabled const): Deleted.
(WebKit::WebViewImpl::showMarkedTextForCandidate): Deleted.
(WebKit::WebViewImpl::showMarkedTextForCandidates): Deleted.
(WebKit::subscribeToTextInputNotifications): Deleted.
(WebKit::extractUnderlines): Deleted.
(WebKit::WebViewImpl::setCaretDecorationVisibility): Deleted.
* Source/WebKit/WebProcess/WebCoreSupport/WebEditorClient.h:
* Source/WebKit/WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::setCaretDecorationVisibility): Deleted.
* Source/WebKitLegacy/mac/WebCoreSupport/WebEditorClient.h:
Canonical link: https://commits.webkit.org/264903@main
More information about the webkit-changes
mailing list