[webkit-changes] [WebKit/WebKit] b3a3c5: Stop propagating text decorations on outermost SVG...

Ahmad Saleem noreply at github.com
Tue Jun 6 06:03:53 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b3a3c589507eb4de25b0be22473e4bacf690922a
      https://github.com/WebKit/WebKit/commit/b3a3c589507eb4de25b0be22473e4bacf690922a
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2023-06-06 (Tue, 06 Jun 2023)

  Changed paths:
    A LayoutTests/svg/text/text-decoration-propagation-2-expected.html
    A LayoutTests/svg/text/text-decoration-propagation-2.html
    A LayoutTests/svg/text/text-decoration-propagation-expected.html
    A LayoutTests/svg/text/text-decoration-propagation.html
    M Source/WebCore/style/StyleAdjuster.cpp

  Log Message:
  -----------
  Stop propagating text decorations on outermost SVG roots

https://bugs.webkit.org/show_bug.cgi?id=248567
rdar://problem/103093226

Reviewed by Antti Koivisto.

This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.

Merge: https://src.chromium.org/viewvc/blink?view=revision&revision=199132

Outermost SVG roots should be consider atomic inline-level, and hence
text decorations should not propagate into them from the outside.

* Source/WebCore/style/StyleAdjuster.cpp:
(isOutermostSVGElement): Add new static function
(shouldInheritTextDecorationsInEffect): Update as per commit
* LayoutTests/svg/text/text-decoration-propagation.html: Add Test Case
* LayoutTests/svg/text/text-decoration-propagation-expected.html: Add Test Case Expectation
* LayoutTests/svg/text/text-decoration-propagation-2.html: Add Test Case
* LayoutTests/svg/text/text-decoration-propagation-2-expected.html: Add Test Case Expectation

Canonical link: https://commits.webkit.org/264894@main




More information about the webkit-changes mailing list