[webkit-changes] [WebKit/WebKit] 434fdb: REGRESSION (262357 at main): WebVTT subtitles with b, ...

[Ryosuke Niwa]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 434fdbe22cf90b1e76c586eeb8da901576e95475
      https://github.com/WebKit/WebKit/commit/434fdbe22cf90b1e76c586eeb8da901576e95475
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2023-06-05 (Mon, 05 Jun 2023)

  Changed paths:
    A LayoutTests/media/resources/vtt-bold-expected.vtt
    A LayoutTests/media/resources/vtt-bold.vtt
    A LayoutTests/media/vtt-bold-expected.html
    A LayoutTests/media/vtt-bold.html
    M Source/WebCore/Modules/mediacontrols/mediaControlsApple.css
    M Source/WebCore/Modules/mediacontrols/mediaControlsBase.css
    M Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css
    M Source/WebCore/css/captions.css
    M Source/WebCore/css/mediaControls.css

  Log Message:
  -----------
  REGRESSION (262357 at main): WebVTT subtitles with b, u, and i has no effect
https://bugs.webkit.org/show_bug.cgi?id=257729

Reviewed by Eric Carlson.

The bug was caused by CSS rules for b, u, and i inside VTT container using
a CSS selector which matches a descendant of a pseudo class.

Adjusted these CSS rules to use attribute selector instead.

* LayoutTests/media/resources/vtt-bold-expected.vtt: Added.
* LayoutTests/media/resources/vtt-bold.vtt: Added.
* LayoutTests/media/vtt-bold-expected.html: Added.
* LayoutTests/media/vtt-bold.html: Added.
* Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:
([pseudo="-webkit-media-text-track-display"] b):
([pseudo="-webkit-media-text-track-display"] u):
([pseudo="-webkit-media-text-track-display"] i):
* Source/WebCore/Modules/mediacontrols/mediaControlsBase.css:
([pseudo="-webkit-media-text-track-display"] b):
([pseudo="-webkit-media-text-track-display"] u):
([pseudo="-webkit-media-text-track-display"] i):
([pseudo="-webkit-media-text-track-display"] .hidden):
* Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css:
([pseudo="-webkit-media-text-track-display"] b):
([pseudo="-webkit-media-text-track-display"] u):
([pseudo="-webkit-media-text-track-display"] i):
([pseudo="-webkit-media-text-track-display"] .hidden):
* Source/WebCore/css/captions.css:
([pseudo="-webkit-media-text-track-display"] b):
([pseudo="-webkit-media-text-track-display"] u):
([pseudo="-webkit-media-text-track-display"] i):
* Source/WebCore/css/mediaControls.css:
([pseudo="-webkit-media-text-track-display"] b):
([pseudo="-webkit-media-text-track-display"] u):
([pseudo="-webkit-media-text-track-display"] i):

Canonical link: https://commits.webkit.org/264888@main